Link and compile against rosbag2_storage_mcap: Fixed issue 1492

[ahcorde]

Fixed issue #1492

How to test it

rm -rf /tmp/colcon-example && mkdir /tmp/colcon-example && cd /tmp/colcon-example
mkdir -p src/example

cat > src/example/CMakeLists.txt <<'EOF'
cmake_minimum_required(VERSION 3.14)
project(example)

find_package(ament_cmake REQUIRED)
find_package(rosbag2_storage_mcap REQUIRED)

file(WRITE empty.cc "")
add_library(${PROJECT_NAME} SHARED empty.cc)

target_link_libraries(${PROJECT_NAME} rosbag2_storage_mcap::rosbag2_storage_mcap)

ament_package()
EOF

cat > src/example/package.xml <<'EOF'
<?xml version="1.0"?>
<?xml-model href="http://download.ros.org/schema/package_format3.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
<package format="3">
  <name>example</name>
  <version>0.0.1</version>
  <description>thing</description>
  <maintainer email="[email protected]">Meh</maintainer>
  <license>Apache-2.0</license>
  <buildtool_depend>ament_cmake</buildtool_depend>
  <depend>rosbag2_storage_map</depend>
  <export>
    <build_type>ament_cmake</build_type>
  </export>
</package>
EOF

source /opt/ros/humble/setup.bash
colcon build

FYI @EricCousineau-TRI

[MichaelOrlov]

@ahcorde Could you please retarget your PR to the Rolling branch?
Our workflow for the fixes is the first fix on Rolling then backport to the other releases.

[ahcorde]

Sure @MichaelOrlov, Done

[ahcorde]

@MichaelOrlov some tests are failing is this expected?

[MichaelOrlov]

@MichaelOrlov some tests are failing is this expected?

Actually not. Those types of test failures are not expected.

[MichaelOrlov]

@ros-pull-request-builder retest this please

[ahcorde]

CI is green, thank you @MichaelOrlov for launching CI again

[clalancette]

CI:

• Linux
• Linux-aarch64
• Windows

[MichaelOrlov]

Re-run Windows CI

• Windows

[MichaelOrlov]

@ahcorde What was a rationale for installing and exporting content of the include folder?
There only one file with visibility macros.
https://github.com/ros2/rosbag2/tree/rolling/rosbag2_storage_mcap/include/rosbag2_storage_mcap

We didn't do this originally for a reason. i.e. it doesn't make any sense.

I would appreciate if you will remove it from delta.

[ahcorde]

• Linux
• Linux-aarch64
• Windows

[clalancette]

Looks good to me, but let's wait for @MichaelOrlov to approve before merging.

[MichaelOrlov]

LGTM.

[MichaelOrlov]

https://github.com/Mergifyio backport iron

[mergify]

backport iron

✅ Backports have been created

• #1497 Link and compile against rosbag2_storage_mcap: Fixed issue 1492 (backport #1496) has been created for branch iron

[MichaelOrlov]

https://github.com/Mergifyio backport humble

[mergify]

backport humble

✅ Backports have been created

• #1498 Link and compile against rosbag2_storage_mcap: Fixed issue 1492 (backport #1496) has been created for branch humble