Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Humble release note about the include directory change. #3703

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Add a Humble release note about the include directory change. #3703

merged 1 commit into from
Jun 5, 2023

Conversation

clalancette
Copy link
Contributor

That is, the fallout from ros2/ros2#1150 should be mentioned for people who are using IDEs with Humble.

While we are in here, do some minor fixes to the formatting of the release notes.

@audrow @sloretz I would appreciate a review from you on this one, as we forgot to add this to the Humble release notes earlier.

@clalancette
Add a Humble release note about the include directory change.
a6ad418 
That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
@clalancette clalancette requested a review from audrow as a code owner June 5, 2023 11:34
@clalancette clalancette added the backport-all backport at reviewers discretion; from rolling to all versions label Jun 5, 2023
@clalancette clalancette linked an issue Jun 5, 2023 that may be closed by this pull request
Humble migration missing a mention of addtion of header file directory layer? #3702
Closed
@clalancette clalancette merged commit d0120d0 into rolling Jun 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the clalancette/update-humble-release-notes branch June 5, 2023 15:53
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
@clalancette @mergify
Add a Humble release note about the include directory change. (#3703)
9b0658d 
That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
@clalancette @mergify
Add a Humble release note about the include directory change. (#3703)
9ea95a1 
That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
@clalancette @mergify
Add a Humble release note about the include directory change. (#3703)
c74b7da 
That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
@clalancette @mergify
Add a Humble release note about the include directory change. (#3703)
7debb18 
That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
@clalancette @mergify
Add a Humble release note about the include directory change. (#3703)
82b2375 
That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)
@mergify mergify bot mentioned this pull request Jun 5, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jun 5, 2023
@clalancette @mergify
Add a Humble release note about the include directory change. (#3703)
2ad254f 
That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)
This was referenced Jun 5, 2023
Merged
Merged
clalancette added a commit that referenced this pull request Jun 5, 2023
@mergify @clalancette
Add a Humble release note about the include directory change. (#3703) (…
d84b2ba 
…#3707)

That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)

Co-authored-by: Chris Lalancette <[email protected]>
clalancette added a commit that referenced this pull request Jun 5, 2023
@mergify @clalancette
Add a Humble release note about the include directory change. (#3703) (…
b725b07 
…#3708)

That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)

Co-authored-by: Chris Lalancette <[email protected]>
clalancette added a commit that referenced this pull request Jun 5, 2023
@mergify @clalancette
Add a Humble release note about the include directory change. (#3703) (…
aa1d97f 
…#3709)

That is, the fallout from ros2/ros2#1150
should be mentioned for people who are using IDEs with
Humble.

While we are in here, do some minor fixes to the formatting
of the release notes.

Signed-off-by: Chris Lalancette <[email protected]>
(cherry picked from commit d0120d0)

Co-authored-by: Chris Lalancette <[email protected]>
130s
130s reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@130s 130s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick addition of this info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@130s 130s 130s left review comments

@sloretz sloretz sloretz approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
backport-all backport at reviewers discretion; from rolling to all versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Humble migration missing a mention of addtion of header file directory layer?
3 participants
@clalancette @130s @sloretz