Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address rqt_reconfigure crashing with IndexError #93

Merged
merged 1 commit into from
Oct 20, 2020

Conversation

rolaechea
Copy link
Contributor

@rolaechea rolaechea commented Oct 2, 2020

This fixes rqt_reconfigure crashing with an index error as reported in bug #92 .

In certain cases, the list of nodes names include an empty string as the name of a node (mostly when a node has crashed or segfaulted) -- looking it up resulted in the index error reported in bug #92 and rqt reconfigure crashing. The solution is just to skip that "node".

@rolaechea rolaechea changed the title Address rqt_reconfigure crashing with IndexError https://github.com/… Address rqt_reconfigure crashing with IndexError Oct 3, 2020
@rolaechea
Copy link
Contributor Author

I agree that a workaround for now is a good idea.

@mjeronimo I don't know the exact root cause, but I do know that the proximate cause is that dynamic_reconfigure.find_reconfigure_services returns an element that is "" when a ros node has not exited properly . And that find_reconfigure_services executes the following code :

def find_reconfigure_services():
import rosservice
return sorted([s[:-len('/set_parameters')] for s in rosservice.get_service_list() if s.endswith('/set_parameters')])

@mjeronimo mjeronimo merged commit e57e912 into ros-visualization:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants