Handle arrays that contain non primitives #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le of a slot_path, for example: "/leds[1]/r"
|
@mjcarroll |
|
@mjcarroll |
|
@mjcarroll Pinging this again. |
|
I believe the issue has been fixed in #33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have an array of non primitive types, the slot_path would be something like "/leds[10]]/r".
This is an unexpected input to
get_slot_type, it should be "/leds/r".A test in rqt_py_common backs this.
627510e is cherry-picked from PR #28, which should be merged first.5c2a603 are the additions for this PR, and handles array that contains non primitives.
Relates to Issue #23.