Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix makefile target test (make test) failing due to "cd test" #951

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

SubaruArai
Copy link
Contributor

@SubaruArai SubaruArai commented Apr 15, 2024

Currently, make test fails on test/test_rosdep_sources_list.py, line 501.
This is due to the CI system running pytest on the project root, while the makefile adds a cd to the test directory before running pytest.

This commit deletes the cd test from the makefile.

Related: #952

Currently, `make test` fails on test/test_rosdep_sources_list.py, line
501.
This is due to the CI system running pytest on the project root, while
the makefile adds a cd to the test directory before running pytest.

This commit deletes the `cd test` from the makefile.
Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, just one comment to address.

Makefile Outdated Show resolved Hide resolved
@cottsay cottsay merged commit 65c0a13 into ros-infrastructure:master Apr 16, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants