Eliminate Pulp from ros_buildfarm #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The createrepo-agent replacement for how we were previously using Pulp is proving to be at least as stable as our Pulp-based solution. It's time to remove all of the unused Pulp-related code from ros_buildfarm.
There was a problem hiding this comment.
I'm not sure whether this is looking for affirmative 👍🏼 right now or just an early read / second set of eyes.
Are all of the operations under scripts/release/rpm/ now served directly via createrepo-agent operations?
Overall looks good. The very basic git grep pulp test comes back successfully absent. Likewise the upload_destination_credential does not appear to be used anywhere else so removing it seems entirely acceptable.
nuclearsandwich
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The createrepo-agent replacement for how we were previously using Pulp is proving to be at least as stable as our Pulp-based solution. It's time to remove all of the unused Pulp-related code from ros_buildfarm.
This absolutely has potential to break things, so I'm going to do some testing on the staging farm prior to marking this PR as ready for review.