Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Pulp operations in Jenkins RPM jobs #979

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Disable Pulp operations in Jenkins RPM jobs #979

merged 1 commit into from
Oct 11, 2022

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Oct 10, 2022

This change leaves much of the Pulp infrastructure code present, but removes Pulp completely from the job execution workflows.

Part of #972

@cottsay
Disable Pulp operations in Jenkins RPM jobs
d1c5c08 
This change leaves much of the Pulp infrastructure code present, but
removes Pulp completely from the job execution workflows.
@cottsay cottsay self-assigned this Oct 10, 2022
@cottsay
Copy link
Member Author

cottsay commented Oct 11, 2022

I ran a handful of test jobs on build.test.ros2.org and there were no failures.

@cottsay cottsay marked this pull request as ready for review October 11, 2022 00:37
nuclearsandwich
nuclearsandwich approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing jumps out as nefarious here. I think the biggest risk is accidentally cutting something still in use but as jobs have already been tested that concern is assuaged.

@cottsay cottsay merged commit 4d3cecc into master Oct 11, 2022
@cottsay cottsay deleted the cottsay/disable_pulp branch October 11, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuclearsandwich nuclearsandwich nuclearsandwich approved these changes

Assignees

@cottsay cottsay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cottsay @nuclearsandwich