Models and API refactor

[gantoine]

This is something I've been meaning to do for a while, with the hopes of improving the clarity of some of our models and the relations between them.

ORM

A few fields were deprecated (p_name, p_igdb_id, p_sgdb_id) and a couple more renamed:

• r_igdb_id -> igdb_id
• r_sgdb_id -> sgdb_id
• r_slug -> slug
• r_name -> name
• p_slug -> plaforms_slug
• n_roms -> rom_count

The PRIMARY key for Platform was moved from fs_slug to slug, to clarify that slug is the true identifier for the platform.

• New relationship between Platform and Rom in the ORM eager joins platform
  • Example: platform_name = rom.platform.name
• Adds a new decorator begin_session that begins sessions and catches errors
• Translate methods to use 2.x sqlalchemy syntax

API

• Now exports a single object by default with all methods on it
  • Means api is now called like so: api.deleteRom({}).then(...)
• All api methods now accept objects as params
  • No need to worry about order of params
• Move some values to url params, form inputs or data where appropriate

Other changes

• Update fastapi + pylance to the latest version
• Improved error handling for file upload
  • Also cleaned up double-loop
• Changed most Rom api paths to no longer start with /platform/{p_slug}
• Rom deletion endpoint accepts delete_from_fs boolean
• rom_exists -> get_rom_by_filename and returns the Rom (or None)
• Give all endpoints explicit response types
• Fixes [Bug] Some games with a / in their title fail to pull IGDB metadata #374

[github-actions]

Test Results

69 tests  ±0   69 ✔️ ±0   25s ⏱️ +8s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 87dfeec. ± Comparison against base commit 8b1dfaa.

♻️ This comment has been updated with latest results.

[zurdi15]

Everything seems really good, just some comments about type notations, but nothing important!