v3.7.1 #1468
Merged
v3.7.1 #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ROMM-1414] Env var to disable user/pass login button
There is a bug in the npm cli such that this does not always happens. The changes were made with https://github.com/jeslie0/npm-lockfile-fix
Fix lockfile to add integrity
[ROMM-1432] Make neogeo aes and mvs games playable in emulatorjs
[ROMM-1431] Allow downloading .3DS files with QR code
Remove SASS library from frontend
Use `authlib` util `get_well_known_url` to get the well-known URL for the OIDC server metadata. This will ensure that the URL is correctly formatted and does not fail when the OIDC server application URL has a trailing slash. Fixes #1430.
fix: Add german language to selector
ci: fix escaping of strings in jq command
…ailing-slash fix: Do not fail when OIDC server application URL has a trailing slash
Fix `json_array_contains_value` function to use the `@>` operator for checking if a JSON array contains a value in PostgreSQL. This is necessary because the `has_key` function only works for string values. Also, remove `get_rom_collections` method, as it was doing the same thing as `get_collections_by_rom_id`. Fixes #1441.
This simplifies avoiding circular imports when trying to use auth handlers.
fix: Use proper JSON contains function for PostgreSQL
misc: Move auth constants to separate file
The OIDC email verified check now fails if the email is explicitly unverified, or if the `email_verified` claim is supported and the email is not explicitly verified. Previously, the OIDC implementation failed for any OIDC provider that did not include the `email_verified` claim in the userinfo response. Providers like Synology do not include this claim, so the check always failed with error "Email is not verified." I haven't found a formal specification for the `email_verified` claim, and how it should be handled, but this implementation should be more robust and work with more OIDC providers. Fixes #1446.
…-check fix: Improve OIDC email verified check
[ROMM-1452] Mark naive datetimes as UTC
[ROMM-1447] Add revision to formatTitle for version switcher
[ROMM-1431] Revert adding .3ds to valid FBI files
[ROMM-1442] Add OIDC_TLS_CACERTFILE path to mounted certfile
Co-authored-by: Zurdi <[email protected]>
[ROMM-1427] Add option to remove game from continue playing
Icon for [OpenBOR game engine](https://github.com/DCurrent/openbor)
Add OpenBOR icon
Bump emulatorjs to 4.2.1
[ROMM-1335] Check for webGL when testing emulatorjs supported
[ROMM-1433] Rework columns in table view
Test Results93 tests 93 ✅ 29s ⏱️ Results for commit ddb51f6. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.