-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Twisted integration #168
base: master
Are you sure you want to change the base?
Conversation
…-stop-recursion Stop logging recursion.
@markrwilliams here's what ends up looping:
|
#172 needs to get addressed and this appears to go towards that, but I'm going to bump this to the next release because getting into the weeds of twisted is not what I want to have hold up a bunch of other changes |
Fixes #163 |
…agent then things will be broken, fix that
This is a tough one dude! Very curious to see how you end up preventing that infinite loop. |
With the current code, as far as I can tell, there are no infinite loops in the case of an SSL error. If you get rid of the add/remove observer stuff then you do get some looping so it appears that is part of the solution. |
This PR will:
Testing:
Status:
Attempting to reproduce some edge casesUseinlineCallbacks
to reduce lines of codeerr.type
inlog_handler
is a specific Twisted Exception or some subclass of one and don't send it back toreport_exc_info
. The nicer alternative would be to somehow tag an error as coming from Rollbar but I'm not quite there yet.