Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Ricardo,
Thanks for this very useful package.
I made this PR just to update the providers list from oembed.com as it has been updated since last time it was copied into your package and it now contains a service I need to handle.
I think there could be a better way to handle this JSON file. Maybe the
OEmbed
class could take an array of providers as an argument?This way users could just store their own array of supported providers in a separate config file instead of relying on the default ones.
I can work on a PR if you are interested in this.