Add .find_by_object interface to findable
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `find_by_object` method to the findable interface, so now if any class extends `findable` module then it will have 2 methods `find` and `find_by_object`, which can be use to initialize a new instance of the class. The `find` interface expect us to provide the `resource_id`, and the `find_by_object` expect us to provide the `object` and it will extract the `resource_id` from that. Sample use cases. ```ruby order = Digicert::Order.find_by_object(Digicert::Order.all.first) order.duplicate ```
|
Added PR #103 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
find_by_objectmethod to the findable interface, so now if any class extendsfindablemodule then it will have 2 methodsfindandfind_by_object, which can be use to initialize a new instance of the class.The
findinterface expect us to provide theresource_id, and thefind_by_objectexpect us to provide theobjectand it will extract theresource_idfrom that. Sample use cases.Note: We are already extending this module in
Digicert::Order, so it should already have this behavior, but if you need the instantiating behavior to any other class then please extend theDigicert::Findablemodule.