apply the fix suggested by https://github.com/ocaml/ocaml-lsp/issues/… #97

mro · 2024-09-26T20:21:17Z

…1069#issuecomment-1684916146

rgrinberg · 2024-09-26T20:22:24Z

Sorry for the obvious question, but did you test that this is enough to make it work on freebsd? Or does it just compile?

coveralls · 2024-09-26T20:29:38Z

Pull Request Test Coverage Report for Build 419

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 76.805%

Totals
Change from base Build 418:	0.0%
Covered Lines:	702
Relevant Lines:	914

💛 - Coveralls

mro · 2024-09-27T17:52:31Z

Hi @rgrinberg,
after having said being clueless what to do and you asking for a pull request, I made exactly that. What were your expectations?

rgrinberg · 2024-09-27T18:21:11Z

I appreciate the PR but I have no way to test it myself. If you could run dune build or even dune runtest in this repo to verify that everything works, I would be grateful. Otherwise, I'll just merge it blindly. Not ideal, but I completely rely on contributors to support anything other than Linux/MacOS/Windows.

mro · 2024-09-28T14:37:02Z

$ uname -aKU
FreeBSD mx250.local 14.1-RELEASE-p5 FreeBSD 14.1-RELEASE-p5 GENERIC amd64 1401000 1401000
$ opam --version
2.1.6
$ echo $SHELL
/usr/local/bin/fish
$ git clone [email protected]:rgrinberg/lev.git ; cd lev

$ opam switch create 5.1.0
$ eval (opam env --switch=5.1.0)
$ opam install . --deps-only --with-test --with-doc --yes
$ dune build
File "lev-fiber/test/dune", line 14, characters 2-19:
14 |   ppx_expect.common
       ^^^^^^^^^^^^^^^^^
Error: Library "ppx_expect.common" not found.
-> required by library "lev_fiber_tests" in _build/default/lev-fiber/test
-> required by
   _build/default/lev-fiber/test/.lev_fiber_tests.objs/native/lev_fiber_tests__Basic.cmx
-> required by _build/default/lev-fiber/test/lev_fiber_tests.a
-> required by alias lev-fiber/test/all
-> required by alias default
...
$ opam install ppx_expect
[NOTE] Package ppx_expect is already installed (current version is v0.17.0).

$ opam switch create 4.13.1-lev 4.13.1
$ eval (opam env --switch=4.14.1-lev)
$ opam install . --deps-only --with-test --with-doc --yes
[ERROR] Package conflict!
  * No agreement on the version of ocaml:
    - (invariant) → ocaml-base-compiler = 4.13.1 → ocaml = 4.13.1
    - lev-fiber → ocaml >= 4.14.0
    You can temporarily relax the switch invariant with `--update-invariant'

No solution found, exiting

$ opam switch create 4.14.1-lev 4.14.1
$ opam install . --deps-only --with-test --with-doc --yes
$ dune build
/usr/local/bin/ld: warning: lev_fiber_util__Bip_buffer.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_csexp.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
lev/vendor/ev.c:514: warning: "EV_USE_INOTIFY" redefined
lev/vendor/ev.c:162: note: this is the location of the previous definition
lev/vendor/ev.c:515: warning: "EV_USE_KQUEUE" redefined
lev/vendor/ev.c:144: note: this is the location of the previous definition
lev/vendor/ev.c:2152:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
/usr/local/bin/ld: warning: lev.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests_signals.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_csexp_tests__Lev_fiber_csexp_rpc_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests_unix.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_tests__Basic.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_util_tests__Bip_buffer_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
$ dune runtest
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

rgrinberg · 2024-09-30T22:44:30Z

Could you try again please? I fixed the ppx_expect issue

mro · 2024-10-01T07:32:59Z

just retry, no other preparatory steps?

$ nice opam switch create 5.1.0
…
$ eval (opam env --switch=5.1.0)
…
$ opam install . --deps-only --with-test --with-doc --yes
…
$ dune build
File "lev/src/dune", line 16, characters 8-10:
16 |  (names ev))
             ^^
lev/vendor/ev.c:514:11: fatal error: sys/statfs.h: No such file or directory
compilation terminated.
File "_none_", line 1:                           
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                           
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                           
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                           
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
/usr/local/bin/ld: warning: lev_fiber_util__Bip_buffer.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_csexp.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
File "_none_", line 1:                           
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                          
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                          
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                          
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                          
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                          
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                          
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                          
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
/usr/local/bin/ld: warning: lev_tests_signals.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests_unix.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_tests__Basic.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_util_tests__Bip_buffer_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_csexp_tests__Lev_fiber_csexp_rpc_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

mro · 2024-10-01T08:03:11Z

after clicking "Sync Fork" my fork and fetching that I get (makes more sense)

$ git clone [email protected]:mro/lev.git ; cd lev
$ git log --oneline -1
f8dfebe (HEAD -> master, origin/master, origin/HEAD) Merge branch 'rgrinberg:master' into master
$ dune clean
$ dune build
File "_none_", line 1:                 
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
/usr/local/bin/ld: warning: lev_fiber_util__Bip_buffer.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
File "_none_", line 1:                 
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                 
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                 
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
/usr/local/bin/ld: warning: lev_fiber.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_csexp.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
lev/vendor/ev.c:514: warning: "EV_USE_INOTIFY" redefined
lev/vendor/ev.c:162: note: this is the location of the previous definition
lev/vendor/ev.c:515: warning: "EV_USE_KQUEUE" redefined
lev/vendor/ev.c:144: note: this is the location of the previous definition
lev/vendor/ev.c:2152:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
/usr/local/bin/ld: warning: lev.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
File "_none_", line 1:                 
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
/usr/local/bin/ld: warning: lev_tests_signals.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_csexp_tests__Lev_fiber_csexp_rpc_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests_unix.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_tests__Basic.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_util_tests__Bip_buffer_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

rgrinberg · 2024-10-01T21:30:27Z

Thanks! I fixed that warning. One more try please.

mro · 2024-10-02T07:37:43Z

# click sync at github fork again
$ git pull
$ git log -3 --oneline
f6876a7 (HEAD -> master, origin/master, origin/HEAD) Merge branch 'rgrinberg:master' into master
fdc6225 chore: add missing unix deps (#100)
f8dfebe Merge branch 'rgrinberg:master' into master
$ opam switch 5.1.0 ; eval (opam env) 
$ dune clean
$ dune build
/usr/local/bin/ld: warning: lev_fiber_util__Bip_buffer.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_csexp.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
lev/vendor/ev.c:514: warning: "EV_USE_INOTIFY" redefined
lev/vendor/ev.c:162: note: this is the location of the previous definition
lev/vendor/ev.c:515: warning: "EV_USE_KQUEUE" redefined
lev/vendor/ev.c:144: note: this is the location of the previous definition
lev/vendor/ev.c:2152:31: warning: 'ev_default_loop_ptr' initialized and declared 'extern'
/usr/local/bin/ld: warning: lev.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
File "_none_", line 1:                 
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
File "_none_", line 1:                
Alert ocaml_deprecated_auto_include: 
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert (e.g. by adding unix to the list of
libraries in your dune file, or adding use_unix to your _tags file for
ocamlbuild, or using -package unix for ocamlfind).
/usr/local/bin/ld: warning: lev_tests_signals.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests_unix.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_csexp_tests__Lev_fiber_csexp_rpc_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_tests__Basic.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_fiber_util_tests__Bip_buffer_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: lev_tests.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

$ dune test
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker
/usr/local/bin/ld: warning: amd64.o: missing .note.GNU-stack section implies executable stack
/usr/local/bin/ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

rgrinberg · 2024-10-04T23:07:19Z

Thanks!

mro · 2024-12-06T11:12:12Z

Hi @rgrinberg,
just wanted to

$ opam switch
#  switch  compiler                    description
   4.12.1  ocaml-base-compiler.4.12.1  4.12.1
→  4.14.2  ocaml-base-compiler.4.14.2  4.14.2
   5.2.1   ocaml-base-compiler.5.2.1   5.2.1
$ opam install ocaml-lsp-server
...
[ERROR] The compilation of ocaml-lsp-server.1.20.1-4.14 failed at "dune build -p ocaml-lsp-server -j 3 @install".

#=== ERROR while compiling ocaml-lsp-server.1.20.1-4.14 =======================#
# context     2.1.6 | freebsd/x86_64 | ocaml-base-compiler.4.14.2 | https://opam.ocaml.org#92bf71cef0f7dba40647ad4c55d91e8125280ed8
# path        /usr/home/mro/.opam/4.14.2/.opam-switch/build/ocaml-lsp-server.1.20.1-4.14
# command     /usr/home/mro/.opam/4.14.2/bin/dune build -p ocaml-lsp-server -j 3 @install
# exit-code   1
# env-file    /usr/home/mro/.opam/log/ocaml-lsp-server-77618-8c29ca.env
# output-file /usr/home/mro/.opam/log/ocaml-lsp-server-77618-8c29ca.out
### output ###
# File "ocaml-lsp-server/dune", line 43, characters 21-23:
# 43 |     (names lev_stubs ev)))))
#                           ^^
# (cd _build/default/ocaml-lsp-server/vendor/lev && /usr/local/bin/gcc -O2 -fno-strict-aliasing -fwrapv -pthread -fPIC -D_FILE_OFFSET_BITS=64 -fdiagnostics-color=always -g -I /usr/home/mro/.opam/4.14.2/lib/ocaml -o ev.o -c ev.c)
# submodules/lev/lev/vendor/ev.c:510:11: fatal error: sys/statfs.h: No such file or directory
# compilation terminated.

What should I do do benefit from the lsp server?

apply the fix suggested by ocaml/ocaml-lsp#1069 (comment)

e8ce3ea

Merge branch 'rgrinberg:master' into master

f8dfebe

Merge branch 'rgrinberg:master' into master

f6876a7

rgrinberg merged commit 5ca101c into rgrinberg:master Oct 4, 2024
6 of 8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

apply the fix suggested by https://github.com/ocaml/ocaml-lsp/issues/… #97

apply the fix suggested by https://github.com/ocaml/ocaml-lsp/issues/… #97

mro commented Sep 26, 2024

rgrinberg commented Sep 26, 2024

coveralls commented Sep 26, 2024 •

edited

Loading

mro commented Sep 27, 2024

rgrinberg commented Sep 27, 2024

mro commented Sep 28, 2024

rgrinberg commented Sep 30, 2024

mro commented Oct 1, 2024 •

edited

Loading

mro commented Oct 1, 2024 •

edited

Loading

rgrinberg commented Oct 1, 2024

mro commented Oct 2, 2024

rgrinberg commented Oct 4, 2024

mro commented Dec 6, 2024

apply the fix suggested by https://github.com/ocaml/ocaml-lsp/issues/… #97

apply the fix suggested by https://github.com/ocaml/ocaml-lsp/issues/… #97

Conversation

mro commented Sep 26, 2024

rgrinberg commented Sep 26, 2024

coveralls commented Sep 26, 2024 • edited Loading

Pull Request Test Coverage Report for Build 419

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

mro commented Sep 27, 2024

rgrinberg commented Sep 27, 2024

mro commented Sep 28, 2024

rgrinberg commented Sep 30, 2024

mro commented Oct 1, 2024 • edited Loading

mro commented Oct 1, 2024 • edited Loading

rgrinberg commented Oct 1, 2024

mro commented Oct 2, 2024

rgrinberg commented Oct 4, 2024

mro commented Dec 6, 2024

coveralls commented Sep 26, 2024 •

edited

Loading

mro commented Oct 1, 2024 •

edited

Loading

mro commented Oct 1, 2024 •

edited

Loading