Chore/build arm64 wheels for osx #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOTE: this means that consumers need to use pip 20.3+ to be able to consume
universal2 wheels.
This was missed in a previous push.
This was referenced Apr 9, 2023
doublethefish
added a commit
that referenced
this pull request
Apr 9, 2023
…ti-arch_lib Fix/pybind11 .so not building multi arch libs on OSX This fixes an issue in PR #53 where the arm64 part of one of, and only one of, the Mach-0 binaries wasn't actually being produced on github actions! This PR switches to separate arm64 and amd64 wheels because the universal2 wheel was not being built properly using github actions because pybind11 wasn't producing a multi-arch .so, however when building locally more than once (as is quite likely) pybind11 would produce and merge (maybe??) the arm64 arch into the amd64 .so. To fix an additional issue when building locally, this also reintroduces a change to clean the build/ intermediary folder for OGDF, because the CMake build for one platform specifies SIMD support that isn't actually available on the 2nd build, and therefore the 2nd build would fail trying to build against the wrong SIMD intrinsics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #35 (you can install from the latest action on master, until we publish to pypi) and fixes #33
Finally we build (cross-compiled) m1 compatible wheels in github actions.