Handle invalid extra closing brace #99
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By the way this PR solves the same problem as #96, but in my opinion in a cleaner way, and comes with an issue and a unit test. I have been using this fix in production for my projects for a while. |
|
Added recursion so the parser handles any number of extra invalid closing braces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks again for the great tool, using it a lot nowadays. The issue raised in #98 has been bothering me quite a lot, since the output from
cssis clearly wrong, but no error is raised. I have tried to adhere to your code style, and I added a (now) passing unit test.If you have issues with the written code but agree that the problem should be fixed, just give me guidance and I can re-write it. I hope we can get this merged in.
Cheers