Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adopt native arm64 github runners #335

Merged
merged 2 commits into from
Jan 20, 2025
Merged

chore: adopt native arm64 github runners #335

merged 2 commits into from
Jan 20, 2025

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Jan 20, 2025

Switch to using the new GitHub-provided arm64 runners (using Ubuntu 24.04).

Now that we're able to, also enable unit test execution on aarch64/Linux.

Note we needed to skip homebrew usage on this platform, since it's not supported.

@reubeno reubeno requested a review from Copilot January 20, 2025 03:30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

.github/workflows/ci.yaml:55

  • The removal of the required tool 'gcc-aarch64-linux-gnu' might cause build failures if this tool is still necessary for the build process.
required_tools: "gcc-aarch64-linux-gnu"
Copy link

github-actions bot commented Jan 20, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 16.31 μs 16.34 μs 0.03 μs ⚪ Unchanged
eval_arithmetic 0.19 μs 0.19 μs -0.00 μs ⚪ Unchanged
expand_one_string 1.54 μs 1.63 μs 0.10 μs 🟠 +6.32%
for_loop 32.45 μs 32.75 μs 0.30 μs ⚪ Unchanged
function_call 3.39 μs 3.50 μs 0.11 μs ⚪ Unchanged
instantiate_shell 49.81 μs 49.43 μs -0.38 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 22230.05 μs 22667.19 μs 437.14 μs ⚪ Unchanged
parse_bash_completion 1675.65 μs 1664.83 μs -10.82 μs ⚪ Unchanged
parse_sample_script 1.76 μs 1.77 μs 0.00 μs ⚪ Unchanged
run_echo_builtin_command 16.31 μs 16.63 μs 0.32 μs ⚪ Unchanged
run_one_external_command 2291.42 μs 2385.24 μs 93.82 μs 🟠 +4.09%
tokenize_sample_script 2.85 μs 2.98 μs 0.12 μs 🟠 +4.35%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/builtins/declare.rs 🟢 81.79% 🟢 81.94% 🟢 0.15%
brush-core/src/env.rs 🟢 88.05% 🟢 87.45% 🔴 -0.6%
brush-core/src/interp.rs 🟢 90.91% 🟢 91.08% 🟢 0.17%
brush-core/src/shell.rs 🟢 77.95% 🟢 77.82% 🔴 -0.13%
brush-core/src/variables.rs 🟢 80.04% 🟢 80.9% 🟢 0.86%
Overall Coverage 🟢 74.68% 🟢 74.73% 🟢 0.05%

Minimum allowed coverage is 70%, this run produced 74.73%

Copy link

github-actions bot commented Jan 20, 2025

Test Results

    3 files     14 suites   5m 12s ⏱️
  601 tests   601 ✅ 0 💤 0 ❌
1 789 runs  1 789 ✅ 0 💤 0 ❌

Results for commit a9f5042.

♻️ This comment has been updated with latest results.

@reubeno reubeno force-pushed the aarch64-runners branch 2 times, most recently from 4a8b80f to 394eee4 Compare January 20, 2025 05:04
@reubeno reubeno merged commit dd1d39c into main Jan 20, 2025
18 checks passed
@reubeno reubeno deleted the aarch64-runners branch January 20, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant