Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollable tab bar #9

Merged
merged 35 commits into from
Nov 10, 2023
Merged

Scrollable tab bar #9

merged 35 commits into from
Nov 10, 2023

Conversation

bennjii
Copy link
Contributor

@bennjii bennjii commented Jul 5, 2023

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scrolling is really nice! But:

I think top_bar_right_ui should be reverted to do what is used to do, top_bar_left_ui removed, and the ⏴ ⏵ buttons added separately (no need to use Behavior for it).

Also, the code needs comments.

examples/advanced.rs Outdated Show resolved Hide resolved
examples/advanced.rs Outdated Show resolved Hide resolved
examples/advanced.rs Outdated Show resolved Hide resolved
src/behavior.rs Outdated Show resolved Hide resolved
src/container/tabs.rs Outdated Show resolved Hide resolved
src/container/tabs.rs Outdated Show resolved Hide resolved
@emilk emilk changed the title Editable Copy of #3 Scrollable tab bar Jul 6, 2023
@bennjii
Copy link
Contributor Author

bennjii commented Jul 6, 2023

Updated it, theres a slight jump when scrolling to the very end as the right menu, I'm tempted to break up the main function tab_bar_ui as well, but it seems arduous.

@emilk emilk added the enhancement New feature or request label Nov 10, 2023
@emilk emilk merged commit 90922d3 into rerun-io:main Nov 10, 2023
5 checks passed
@bennjii bennjii deleted the scroll-indicators branch November 10, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants