Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle torch version not set #61

Closed
wants to merge 1 commit into from
Closed

Handle torch version not set #61

wants to merge 1 commit into from

Conversation

8W9aG
Copy link
Contributor

@8W9aG 8W9aG commented Jan 14, 2025

  • When setting the virtualenv we need to consider whether the torch version has been set.
  • If it hasn’t we need to create a virtualenv without torch as an option

@8W9aG
Handle torch version not set
e941673 
* When setting the virtualenv we need to consider
whether the torch version has been set.
* If it hasn’t we need to create a virtualenv
without torch as an option
@8W9aG 8W9aG requested a review from a team as a code owner January 14, 2025 15:29
@nevillelyh
Copy link
Contributor

Discussed IRL. This approach assumes we install a torch-less venv, which basically has no pkgs other than pip setuptools & wheel. And we can just skip the monobase venv and construct PYTHONPATH with user+cog layers only. I'll fix up.

@nevillelyh
Copy link
Contributor

#63

@nevillelyh nevillelyh closed this Jan 15, 2025
@8W9aG 8W9aG deleted the sackfield/handle-torchversion-not-set branch January 15, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erbridge erbridge erbridge approved these changes

@meatballhat meatballhat Awaiting requested review from meatballhat

@nevillelyh nevillelyh Awaiting requested review from nevillelyh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@8W9aG @nevillelyh @erbridge