Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer monobase:latest on top of monobase-runtime:latest #51

Closed
wants to merge 1 commit into from

Conversation

nevillelyh
Copy link
Contributor

No description provided.

@nevillelyh nevillelyh requested a review from a team as a code owner January 9, 2025 22:05
&& tar --strip-components=1 -C /tmp/r8 -xf $(find /tmp/build-layer/src/dist -name '*.tar.gz' | head -1) \
&& cp -v /tmp/r8/src/monobase/*.sh /tmp/r8/src/monobase/pget /opt/r8/monobase/ \
&& cp -v /tmp/r8/src/monobase/build.sh /tmp/r8/src/monobase/pget /opt/r8/monobase/ \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only other *.shs are activate.sh & exec.sh


RUN --mount=type=bind,src=../../,dst=/src,ro \
RUN --mount=type=bind,src=.,dst=/src,ro \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what ../../ means, shouldn't it be . i.e. PWD of project root? Why did it work before?

@nevillelyh
Copy link
Contributor Author

nevillelyh commented Jan 9, 2025

Looks like we might need to get rid the matrix & build/push both images in a single step. We probably don't want to do it in 2 separate steps and have monobase:latest pull FROM a just published monobase-runtime:latest.

OTOH what exactly is the motivation of splitting? We're not saving space due to ~600MBs of apt pkgs in both, which is actually only needed in runtime not builder. While the only addition in builder are requirements files & a few Python scripts. Neither docker build not the GHAs support multiple images from a single build making this more annoying than need be.

@nevillelyh
Copy link
Contributor Author

nevillelyh commented Jan 10, 2025

which is actually only needed in runtime not builder

Turns out this is not true, we need it in monobase the builder image which is the base for new layered cog build. So the only diff of monobase-runtime are those requirements.txt and Python builder scripts.

@nevillelyh
Copy link
Contributor Author

Discussed over Slack. Abandoning this and going with 1 image to simplify things.

@nevillelyh nevillelyh closed this Jan 10, 2025
@nevillelyh nevillelyh deleted the neville/build branch January 10, 2025 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant