-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layer monobase:latest on top of monobase-runtime:latest #51
Conversation
4ecb3aa
to
8de1746
Compare
8de1746
to
3a001c4
Compare
&& tar --strip-components=1 -C /tmp/r8 -xf $(find /tmp/build-layer/src/dist -name '*.tar.gz' | head -1) \ | ||
&& cp -v /tmp/r8/src/monobase/*.sh /tmp/r8/src/monobase/pget /opt/r8/monobase/ \ | ||
&& cp -v /tmp/r8/src/monobase/build.sh /tmp/r8/src/monobase/pget /opt/r8/monobase/ \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only other *.sh
s are activate.sh
& exec.sh
|
||
RUN --mount=type=bind,src=../../,dst=/src,ro \ | ||
RUN --mount=type=bind,src=.,dst=/src,ro \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what ../../
means, shouldn't it be .
i.e. PWD of project root? Why did it work before?
Looks like we might need to get rid the matrix & build/push both images in a single step. We probably don't want to do it in 2 separate steps and have OTOH what exactly is the motivation of splitting? We're not saving space due to ~600MBs of apt pkgs in both, which is actually only needed in runtime not builder. While the only addition in builder are requirements files & a few Python scripts. Neither |
Turns out this is not true, we need it in |
Discussed over Slack. Abandoning this and going with 1 image to simplify things. |
No description provided.