refactor(core): remove duplicated overtime intervals #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9cf1d91 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
refine
|
||||||||||||||||||||||||||||
| Project |
refine
|
| Branch Review |
refactor/remove-duplicate-overtime
|
| Run status |
|
| Run duration | 19m 15s |
| Commit |
|
| Committer | Ali Emir Şen |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
22
|
Skipped
|
0
|
Passing
|
378
|
| View all changes introduced in this branch ↗︎ | |
alicanerdurmaz
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
Changes
Added missing
enabledprop touseLoadingOvertimeand added ability to globally configure throughoptions.overtime.enabled.Due to the nature of calculating elapsed time, an interval is set by the
intervalprop. This was causing unwanted updates in the return value and there was no way to disable it properly.Updated Refine's data hooks and extensions to prevent duplicated overtime intervals from being created. This uses the
enabledprop to prevent internal hooks from registering the intervals.Prior to this change,
useTablewas initializing its ownuseLoadingOvertimehook but also propagated theelapsedTimefromuseListhook which is used internally byuseTable. This caused duplicated intervals and unwanted updates.This now ensures a single interval is created and used for the extension hooks.
WIP Extension hooks from packages outside
@refinedev/core; such as@refinedev/antddoesn't export overtime values properly.Fixes #6625