Schema Evolution & Compatability & Whatnot #24676
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleiman
force-pushed
the
dlib/core-8525/compat-visitor
branch
2 times, most recently
from
961b6dc to
2052d15
Compare
variant:
- bool is_new
- bool removed
- struct src_info
- id of the source field
- requiredness of the source field
- optionally source field type (if primitive)
Used in subsequent commits to:
- cheaply identify struct fields that have changed shape
- defer type & requiredness invariant checks to the end
Only track primitive types because
a) they are cheap to copy and
b) structured types are effectively checked during traversal
Templatize the visitor to add a const nested_field* version.
oleiman
force-pushed
the
dlib/core-8525/compat-visitor
branch
from
2052d15 to
b2d3ba0
Compare
TODO: comments
And lightly refactor test suite base class for reuse
Make a copy of the destination schema. Generate a schema transform from source to dest. Apply the transform to the copy and return the result (or an error code)
Generates increasingly nested structs and measures the time it takes to: - collect all fields of two copies w/ field_collecting_visitor - generate a schema transform from one copy to another - visit a generated schema transform Serves as a decent point of comparison between the limited schema verification already present in the tree and the utilities introduced in this commit stack.
oleiman
force-pushed
the
dlib/core-8525/compat-visitor
branch
from
b2d3ba0 to
a845692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.
Backports Required
Release Notes