-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure and rephrase README #437
base: master
Are you sure you want to change the base?
Conversation
Maybe we should keep some piece of existing README?
Also adding |
Thanks for your feedback.
That's a good idea, I'd gladly add that too. To sum it up, i would bring back the slogan, a compressed version of Features, possibly the debugger tip, the example and CGLM_OMIT_NS_FROM_STRUCT_API. Let me know how you feel about this. If it's good, I'll push an update. |
Not actually. Library do alignment on local variables only ( consider user has float array and pass it to mat4 funcs..., or alignment is enabled on cglm side but disabled in user space... ). If vec4/mat4 is not aligned on user side correctly there will be unexpected results like weird crashes... For instance mat4 m1, m2, m3;
glm_mat4_mul(m1, m2, m3);
another example: mat4 m1, m2;
void *m3;
glm_mat4_mul(m1, m2, m3); m1, m2 is aligned with
Before switching to building, I think we must let them know the design. Inline api, Call api Struct Api, Simd Api...
I guess this is relevant to alignment I mentioned above.
maybe full list for now :) plus Thanks |
@recp I updated the PR, let me know if there's anything else to change. |
The current README.md contains a lot of redundant information which makes it hard to spot the actually important pieces. This pull request does the following:
As the readme is the first thing anyone sees when finding this repo, I think it's important that it leaves a good impression and gets the most important information across as efficiently as possible.
Futher work could be done on BUILDING.md. As it is not as visible as the README, I've left it virtually unchanged, only rephrasing the titles.