Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting __partitioned__ interface #153

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Supporting __partitioned__ interface #153

merged 5 commits into from
Oct 13, 2021

Conversation

fschlimb
Copy link
Contributor

Initial implementation for #152 .

Once MLDataSet and modin have support for partitioned in mainline their specialized implementation could be removed without limiting any functionality.

krfricke
krfricke reviewed Sep 14, 2021
View reviewed changes
Copy link
Collaborator

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a very thorough PR.

I just triggered CI so we can see if the tests pass. Can you also add the example to run_ci_examples.sh in the root directory?

xgboost_ray/matrix.py Outdated Show resolved Hide resolved
xgboost_ray/data_sources/partitioned.py Outdated Show resolved Hide resolved
@fschlimb
Copy link
Contributor Author

Thank you, this is a very thorough PR.

I just triggered CI so we can see if the tests pass. Can you also add the example to run_ci_examples.sh in the root directory?

CI doesn't seem start anymore.

@krfricke
Copy link
Collaborator

Ah sorry, it seems I have to manually trigger it every time. Just did!

@fschlimb
Copy link
Contributor Author

I have no idea how my changes could make any other test fail.

@Yard1
Copy link
Member

Yard1 commented Sep 16, 2021

Looks like tests are being flaky on their own

@fschlimb fschlimb mentioned this pull request Sep 27, 2021
Closed
7 tasks
@fschlimb fschlimb mentioned this pull request Oct 6, 2021
Open
krfricke
krfricke approved these changes Oct 13, 2021
View reviewed changes
Copy link
Collaborator

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@krfricke krfricke merged commit b5d725a into ray-project:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 left review comments

@krfricke krfricke krfricke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fschlimb @krfricke @Yard1