Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll back to @nuxtjs/eslint-config-typescript 11.0.0 #3518

Closed
wants to merge 1 commit into from

Conversation

ericpromislow
Copy link
Contributor

Fixes #3516

For some reason, many (but not all) of our eslint-disable-* directives aren't used, or they are reported as not being needed.

This issue is that using "@nuxtjs/eslint-config-typescript v 12.0.0 has the effect of sort of enabling the --report-unused-disable-directives flag for eslint, although problems are reported as warnings, not errors, and if that's the only thing eslint reports, it returns with status 0, which is why this isn't a problem for CI.

Signed-off-by: Eric Promislow [email protected]

@ericpromislow
Copy link
Contributor Author

The commit that broke eslint-disable-next-line checking: 2f4887a

diff --git a/package.json b/package.json
index 1b803e7f..f35d0d94 100644
--- a/package.json
+++ b/package.json
@@ -72,7 +72,7 @@
     "yaml": "^1.10.2"
   },
   "devDependencies": {
-    "@babel/eslint-parser": "^7.12.1",
+    "@babel/eslint-parser": "^7.17.0",
     "@nuxt/types": "^2.15.2",
     "@nuxt/typescript-build": "^2.1.0",
     "@nuxtjs/eslint-config": "^8.0.0",
@@ -89,8 +89,8 @@
     "@types/node-forge": "^0.9.7",
     "@types/semver": "^7.3.4",
     "@types/tar-stream": "^2.2.1",
-    "@typescript-eslint/eslint-plugin": "^4.17.0",
-    "@typescript-eslint/parser": "^4.17.0",
+    "@typescript-eslint/eslint-plugin": "^5.14.0",
+    "@typescript-eslint/parser": "^5.14.0",
     "@vue/test-utils": "^1.1.2",
     "babel-core": "^7.0.0-bridge.0",
     "cache-loader": "^4.1.0",
@@ -101,7 +101,7 @@
     "eslint": "^8.10.0",
     "eslint-plugin-deprecation": "^1.2.1",
     "eslint-plugin-nuxt": "^3.1.0",
-    "eslint-plugin-vue": "^8.4.1",
+    "eslint-plugin-vue": "^8.5.0",
     "extract-zip": "^2.0.1",
     "jest": "^27.4.7",
     "js-yaml-loader": "^1.2.2",

@ericpromislow
Copy link
Contributor Author

Filed possible upstream issue: nuxt/eslint#243

This would fix the bogus reporting problem, but the disable check started creating false positives in the above commit from March 2022.

@ericpromislow
Copy link
Contributor Author

Wrong approach.

@jandubois jandubois deleted the 3516-fix-failing-eslint-directives branch January 23, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deal with unused eslint-disable directives.
1 participant