Allow Rails 8 #30
Merged
Allow Rails 8 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonid-shevtsov
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
I am OK with this change.
Ideally we should test against each supported rails version with appraisals as we do in https://github.com/railsware/mailtrap-ruby
|
Should be ok considering that there were no changes to the Action Mailer after 7.2. I'll double check everything is working and will merge the PR later today. https://github.com/rails/rails/blob/8-0-stable/actionmailer/CHANGELOG.md |
i7an
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the restriction Rails versions below 8. See svenfuchs/rails-i18n#1130 for a discussion around the merits of this. Thanks in advance for your consideration.