Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling cache in the setup-go steps of CI/CD #8147

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ytimocin
Copy link
Contributor

Description

Disabling cache in the setup-go steps of our CI/CD pipelines.

Ref: actions/setup-go#403 (comment)

Type of change

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
  • If applicable, design document has been reviewed and approved by Radius maintainers/approvers.
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.

@ytimocin ytimocin requested review from a team as code owners December 17, 2024 18:34
Copy link

github-actions bot commented Dec 17, 2024

Unit Tests

3 526 tests  ±0   3 522 ✅ ±0   5m 5s ⏱️ -6s
  287 suites ±0       4 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 233b9b8. ± Comparison against base commit 710509a.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.07%. Comparing base (710509a) to head (233b9b8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8147      +/-   ##
==========================================
- Coverage   60.09%   60.07%   -0.02%     
==========================================
  Files         584      584              
  Lines       38675    38675              
==========================================
- Hits        23240    23234       -6     
- Misses      13729    13732       +3     
- Partials     1706     1709       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytimocin ytimocin force-pushed the ytimocin/setup-go/disable-cache branch from 76d2fc6 to 233b9b8 Compare January 2, 2025 17:09
@ytimocin ytimocin temporarily deployed to functional-tests January 2, 2025 17:09 — with GitHub Actions Inactive
@radius-functional-tests
Copy link

radius-functional-tests bot commented Jan 2, 2025

Radius functional test overview

🔍 Go to test action run

Name Value
Repository radius-project/radius
Commit ref 233b9b8
Unique ID funcb9a1b17d76
Image tag pr-funcb9a1b17d76
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-funcb9a1b17d76
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-funcb9a1b17d76
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-funcb9a1b17d76
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-funcb9a1b17d76
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-funcb9a1b17d76
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

Copy link
Contributor

@kachawla kachawla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some background in the description on why this change is being made, what are the drawbacks of disabling it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run actions/cache@v4 step in functional tests spams thousands of log lines
2 participants