Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(favicon): align favicon color with QwikUI logo #475

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Nov 3, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

So that I can know which tab is qwik-ui and which tab is qwik 😅

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@gioboa
Copy link
Contributor

gioboa commented Nov 4, 2023

The Qwik logo has two colors and we would like to respect the original aspect.

@gioboa
Copy link
Contributor

gioboa commented Nov 4, 2023

So that I can know which tab is qwik-ui and which tab is qwik 😅

I understand your needs but I close this PR because we don't want to change the original Qwik logo.

@gioboa gioboa closed this Nov 4, 2023
@gioboa
Copy link
Contributor

gioboa commented Nov 4, 2023

Thanks @maiieul for your commitment.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
@qwikifiers qwikifiers unlocked this conversation Nov 4, 2023
@gioboa
Copy link
Contributor

gioboa commented Nov 4, 2023

@maiieul The Qwik UI logo is all blue so you are right, this PR has sense. I will merge it.

@gioboa gioboa reopened this Nov 4, 2023
@gioboa gioboa changed the title feat(favicon.svg): change favicon colors to full light-blue chore(favicon): align favicon color with QwikUI logo Nov 4, 2023
@gioboa gioboa merged commit d109e8c into qwikifiers:main Nov 4, 2023
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2023
@maiieul maiieul deleted the favicon branch November 11, 2023 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants