Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(package.json & contributing.md): add pnpm link.dist script #474

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

maiieul
Copy link
Contributor

@maiieul maiieul commented Nov 2, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

First PR 🤓

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link
Contributor

github-actions bot commented Nov 2, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@maiieul
Copy link
Contributor Author

maiieul commented Nov 2, 2023

I have read the CLA Document and I hereby sign the CLA

@maiieul
Copy link
Contributor Author

maiieul commented Nov 2, 2023

recheck

github-actions bot added a commit that referenced this pull request Nov 2, 2023
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just re-organized by alphabetical order and added "link.dist"

@thejackshelton
Copy link
Collaborator

Looks good to me! Merging.

The CI error seems to be a problem with GitHub and the "danger bot" for first time contributors.

@thejackshelton thejackshelton merged commit 355a5fb into qwikifiers:main Nov 3, 2023
1 of 2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2023
@gioboa
Copy link
Contributor

gioboa commented Nov 4, 2023

@all-contributors please add @maiieul for code, ideas, maintenance

@maiieul maiieul deleted the pnpm-link branch November 11, 2023 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants