fix: sparkline should be relative to values instead of zero; zero dividend/divisior issue; sub-pixel issue. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code was considering 0 to be the base value for Y axis so the charts appeared to now show relative movements not as clearly as the numbers increased in value. For example, the sparkline for `[110, 120, 130, 110, 120, 130]` would appear flatter than `[10, 20, 30, 10, 20, 30]` even though the relative differences between the numbers is the same. As the numbers go higher (1000s), the line visually appears to be a straight line. Please see the screenshot below for reference. https://i.imgur.com/HMyqPU9.png Sandbox with the change: https://codesandbox.io/p/sandbox/pedantic-hawking-hzwsgl?file=%2Fsrc%2Flib%2Fsparkline-svg.ts%3A29%2C9-32%2C10
The horizontal line was appearing as 1px incorrectly even when stroke-width was set to 2; vertical or diagonal lines were appearing as 2px correctly. More info at: https://stackoverflow.com/a/12502840/3577736 Other solutions on the stackoverflow thread did not work.
prathamesh-gharat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was considering 0 to be the base value for Y axis so the sparkline currently does not show relative movements in values clearly.
For example, the sparkline for
[110, 120, 130, 110, 120, 130]would appear flatter than[10, 20, 30, 10, 20, 30]even though the relative differences between the numbers is the same. As the numbers go higher (1000s), the line visually appears to be a straight line.Please see the screenshot below for reference.
https://i.imgur.com/HMyqPU9.png
Sandbox with the change: https://codesandbox.io/p/sandbox/pedantic-hawking-hzwsgl?file=%2Fsrc%2Flib%2Fsparkline-svg.ts%3A29%2C9-32%2C10