[Feat] TriggerBuilder: TriggerBuilder's startAt Method Settings Type Extension #1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Can also be set to LocalDateTime or ZonedDateTime type without conversion to Date type Signed-off-by: hwangjeyeon <[email protected]>
- First Test, Is the time in the format LocalDateTime applied to the trigger well - Second Test, After the start time, make sure the trigger is working well (Decided as last FireTime) Signed-off-by: hwangjeyeon <[email protected]>
|
I don't understand the use case for LocalDateTime. LocalDateTime has very few real world use cases and is typically used incorrectly. ZonedDateTime is also somewhat misunderstood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the triggerBuilder's startAt type setting. Previously, only Date types could be delivered, so the user did the type conversion, but now LocalDateTime and ZonedDateTime can also be delivered without type conversion.
Changes
Checklist