Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression: "L" last day of month specifier with short months won't be triggered #1284

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

curegit
Copy link

@curegit curegit commented Dec 9, 2024

This PR fixes that Cron's "L" last day of the month schedules are never triggered in short months (without a 31st day).

Problem probably introduced in #1175, between 2.5.0-rc1 and 2.5.0-rc2.

Changes

  • Fix day calculation for "L" last day of month specifiers (including offset ones) with short months
  • Add tests to prevent regressions due to month length

Checklist

  • tested locally
  • updated the docs
  • added appropriate test
  • signed-off on the DCO referenced in the CONTRIBUTING link below via git commit -s on my commits, and submit this code under terms of the Apache 2.0 license and assign copyright to the Quartz project owners
    (If you're not using command-line, you can use a browser extension )

In submitting this contribution, I agree to the terms of contributing as referred to here:
https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md

@curegit curegit changed the title Fix regression: "L" last day of month specifier with short months Fix regression: "L" last day of month specifier with short months won't be triggered Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants