Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(proxy): HTTP_PROXY env variable was not removed after os_env_proxy wrapper #596

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix(proxy): HTTP_PROXY env variable was not removed after os_env_proxy wrapper #596

merged 1 commit into from
Dec 6, 2024

Conversation

jmkerloch
Copy link
Collaborator

  • we restored only if variable defined
  • need to remove if no variable defined

@jmkerloch
fix(proxy): HTTP_PROXY env variable was not removed after os_env_prox…
e480387 
…y wrapper:

- we restored only if variable defined
- need to remove if no variable defined
@jmkerloch jmkerloch added the bug Something isn't working label Dec 6, 2024
@jmkerloch jmkerloch requested a review from Guts December 6, 2024 16:10
@jmkerloch jmkerloch self-assigned this Dec 6, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Dec 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
qgis_deployment_toolbelt/utils/proxies.py 0.00% 2 Missing and 2 partials ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   70.35%   70.26%   -0.09%     
==========================================
  Files          47       47              
  Lines        3188     3192       +4     
  Branches      558      560       +2     
==========================================
  Hits         2243     2243              
- Misses        747      749       +2     
- Partials      198      200       +2
Flag Coverage Δ
unittests 69.70% <0.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
qgis_deployment_toolbelt/utils/proxies.py 58.44% <0.00%> (-3.21%) ⬇️

@jmkerloch jmkerloch merged commit 97fcf01 into main Dec 6, 2024
25 checks passed
@jmkerloch jmkerloch deleted the fix/os_env_proxy_wrapper branch December 6, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Guts Guts Guts approved these changes

Assignees

@jmkerloch jmkerloch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmkerloch @Guts