Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change note about deprecated ScalarizedObjective in favor of ScalarizedPosteriorTransform #1898

Closed
wants to merge 1 commit into from

Conversation

sgbaird
Copy link
Contributor

@sgbaird sgbaird commented Jun 21, 2023

Motivation

The example usage at the end was already updated to use ScalarizedPosteriorTransform.

facebook/Ax#1312

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

N/A

Related PRs

Doc change

…edPosteriorTransform

The example usage at the end was already updated to use `ScalarizedPosteriorTransform`.

facebook/Ax#1312
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 21, 2023
@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1898 (1141e44) into main (5a8d27c) will not change coverage.
The diff coverage is n/a.

❗ Current head 1141e44 differs from pull request most recent head 4a23a6b. Consider uploading reports for the commit 4a23a6b to get more accurate results

@@            Coverage Diff            @@
##              main     #1898   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          173       173           
  Lines        15194     15194           
=========================================
  Hits         15194     15194           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@saitcakmak saitcakmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@saitcakmak has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@esantorella esantorella self-requested a review June 21, 2023 00:37
Copy link
Member

@esantorella esantorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@facebook-github-bot
Copy link
Contributor

@saitcakmak merged this pull request in e5bf538.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants