-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check for empty description when converting metadata #646
Check for empty description when converting metadata #646
Conversation
To prevent an exception, check for an empty description Fixes: pypa#645
for more information, see https://pre-commit.ci
There's no specified behavior of what the description should be if empty - To match the existing behavior as much as possible (where an extra newline is appended), I did the same in this PR. Let me know if you'd like a different default value |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
==========================================
+ Coverage 78.21% 78.25% +0.03%
==========================================
Files 14 14
Lines 1120 1122 +2
==========================================
+ Hits 876 878 +2
Misses 244 244 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a changelog entry (in docs/news.rst
)
Looks like there was a mishap with syntax. If you'll just sort that out and add the changelog entry, we're good for merging. |
Co-authored-by: Alex Grönholm <[email protected]>
c10fd1a
to
8d480b8
Compare
Please don't force push. You just overwrote my edits to |
Ah sorry about that :) Different habits for fixing issues. I don't have your version in my reflog unfortunately. Did you want to take a stab at fixing the news.rst to your liking? |
I've pushed my edits now. |
Thanks. |
To prevent an exception, check for an empty description Fixes: #645
Test plan: Run the unit tests without the fix -> Fails with an exception. Passes after the fix