Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for empty description when converting metadata #646

Merged
merged 6 commits into from
Jan 5, 2025

Conversation

intentionally-left-nil
Copy link
Contributor

@intentionally-left-nil intentionally-left-nil commented Jan 3, 2025

To prevent an exception, check for an empty description Fixes: #645

Test plan: Run the unit tests without the fix -> Fails with an exception. Passes after the fix

intentionally-left-nil and others added 2 commits January 3, 2025 15:06
To prevent an exception, check for an empty description Fixes: pypa#645
@intentionally-left-nil
Copy link
Contributor Author

There's no specified behavior of what the description should be if empty - To match the existing behavior as much as possible (where an extra newline is appended), I did the same in this PR. Let me know if you'd like a different default value

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.25%. Comparing base (426b8dd) to head (6f7bdcd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #646      +/-   ##
==========================================
+ Coverage   78.21%   78.25%   +0.03%     
==========================================
  Files          14       14              
  Lines        1120     1122       +2     
==========================================
+ Hits          876      878       +2     
  Misses        244      244              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry (in docs/news.rst)

src/wheel/cli/convert.py Outdated Show resolved Hide resolved
@agronholm
Copy link
Contributor

Looks like there was a mishap with syntax. If you'll just sort that out and add the changelog entry, we're good for merging.

@agronholm
Copy link
Contributor

Please don't force push. You just overwrote my edits to news.rst.

@intentionally-left-nil
Copy link
Contributor Author

Ah sorry about that :) Different habits for fixing issues. I don't have your version in my reflog unfortunately. Did you want to take a stab at fixing the news.rst to your liking?

@agronholm
Copy link
Contributor

I've pushed my edits now.

@agronholm agronholm merged commit edb5f7a into pypa:main Jan 5, 2025
16 checks passed
@agronholm
Copy link
Contributor

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

convert_pkg_info raises an exception if the description is empty
2 participants