-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Patch] Set the default runner to ubuntu-22.04
and expose it as input everywhere
#135
Conversation
|
shall we also set the default to Edit: nevermind, I just did it. if you object this one, we can just revert the resp. commit. |
ubuntu-22.04
and expose it as input everywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good to me.
It turns out I was likely wrong that this was an image bug and is rather a new "feature" of the latest ubuntu itself. I still like this as a short term patch while we get things rolling, but I opened a new issue (#136) to discuss a more long-term solution -- almost certainly one of the ideas you already proposed elsewhere.
Ah, @mbruns91, wait! It looks like
This PR should still go forward to expose the runner arg, but we can probably get away without updating the default image. |
Yep, it's rolled back to 22.04 already. Let's ditch the default change, but keep the runner exposure at input |
I do not strongly object this, but personally I'd prefer to "properly" define the default runner. This makes it less ambiguous on what backend our CI tasks are running. |
I can live with an explicitly pinned default, go for merge |
I pick up this one