Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation via Poetry v1.4.0 fails #1253

Closed
dlqqq opened this issue Mar 19, 2023 · 13 comments
Closed

Installation via Poetry v1.4.0 fails #1253

dlqqq opened this issue Mar 19, 2023 · 13 comments

Comments

@dlqqq
Copy link
Contributor

dlqqq commented Mar 19, 2023

Description

The 1.4.0 release of Poetry introduced a controversial breaking change that changes the installer package Poetry uses. The new installer flat-out rejects installation of certain wheels with malformed metadata in RECORD. One of these wheels is pydata_sphinx_theme. This is the output from poetry install -E all:

  ["In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/__init__.py didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/assets/scripts/index.js didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/assets/styles/_admonitions.scss didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/assets/styles/_api.scss didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/assets/styles/_base.scss didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/assets/styles/_markdown.scss didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/assets/styles/_navbar.scss didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/assets/styles/_versionmodified.scss didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/assets/styles/index.scss didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/bootstrap_html_translator.py didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/copyright.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/edit-this-page.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/last-updated.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/navbar-icon-links.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/navbar-logo.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/navbar-nav.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/page-toc.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/prev-next.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/sidebar-ethical-ads.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/sidebar-nav-bs.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/sphinx-version.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/_templates/version-switcher.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/docs-navbar.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/docs-sidebar.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/footer.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/icon-links.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/layout.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/search-field.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/.gitignore didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/scripts/pydata-sphinx-theme.js didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/styles/pydata-sphinx-theme.css didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/styles/theme.css didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/LICENSE.txt didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/css/all.min.css didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-brands-400.eot didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-brands-400.svg didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-brands-400.ttf didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-brands-400.woff didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-brands-400.woff2 didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-regular-400.eot didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-regular-400.svg didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-regular-400.ttf didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-regular-400.woff didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-regular-400.woff2 didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-solid-900.eot didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-solid-900.svg didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-solid-900.ttf didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-solid-900.woff didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/vendor/fontawesome/5.13.0/webfonts/fa-solid-900.woff2 didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/static/webpack-macros.html didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme/theme/pydata_sphinx_theme/theme.conf didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme-0.8.1.dist-info/LICENSE didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme-0.8.1.dist-info/METADATA didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme-0.8.1.dist-info/WHEEL didn't match RECORD", "In /home/dlq/.cache/pypoetry/artifacts/5e/51/c0/f6facc1d51b1bbc97a5abce1b4e7219c054be65cbd3d6a2a39f0e20d4a/pydata_sphinx_theme-0.8.1-py3-none-any.whl, hash / size of pydata_sphinx_theme-0.8.1.dist-info/entry_points.txt didn't match RECORD"]

  at /local~/.local/share/pypoetry/venv/lib/python3.9/site-packages/installer/sources.py:289 in validate_record
      285│                         f"In {self._zipfile.filename}, hash / size of {item.filename} didn't match RECORD"
      286│                     )
      287│
      288│         if issues:
    → 289│             raise _WheelFileValidationError(issues)
      290│
      291│     def get_contents(self) -> Iterator[WheelContentElement]:
      292│         """Sequential access to all contents of the wheel (including dist-info files).
      293│

Steps to reproduce

First, install the latest version of Poetry. Then, in your terminal:

poetry new poetry-demo
cd poetry-demo
poetry add pydata_sphinx_theme # <= verify this fails
@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 20, 2023

Did some digging. Poetry 1.4.0 now defaults to using the installer installer instead of pip. The breaking change was implemented in pypa/installer#147, which was then first included in a release in 0.7.0, 2 days ago.

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 20, 2023

The next release will hopefully include a CLI for verifying wheel RECORDs: pypa/installer#161

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 20, 2023

It looks like the default install procedure doesn't even validate the record; python -m installer <path-to-wheel> passes just fine locally, and I don't see WheelFile#validate_record() (failing method in question) being called anywhere else besides tests. This bug is basically exclusive to Poetry builds because of they call WheelFile#validate_record() explicitly as a pre-install step: https://github.com/python-poetry/poetry/pull/7671/files#diff-6e4b362f2ca86526a481a87d23c626c3bc2e06998bac8c35c71ae4988f9fe3ef

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 20, 2023

Finally managed to reproduce this bug locally. First, build the wheel locally from the repo root:

pip install sphinx_theme_builder
stb package

Then, run this script from the repo root:

import os
from installer.sources import WheelFile

WHEEL_RELPATH = 'dist/pydata_sphinx_theme-0.13.2.dev0-py3-none-any.whl'

wheel_abspath = os.path.join(os.path.dirname(__file__), WHEEL_RELPATH)

with WheelFile.open(wheel_abspath) as source:
    source.validate_record()

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 20, 2023

Cut a PR upstream to fix this: pradyunsg/sphinx-theme-builder#39

@pantelis
Copy link

pantelis commented Mar 20, 2023

Thank you. We can also confirm that this also happens with Poetry 1.4.1 and Github CI settings despite the setting installer.modern-installation: false that we read in the poetry issues that is a workaround.

  • name: Install Poetry
    uses: snok/install-poetry@v1
    with:
    virtualenvs-create: true
    virtualenvs-in-project: true
    installer-parallel: true
    installer.modern-installation: false

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 20, 2023

@pantelis The next steps are:

  • Wait for a new sphinx-theme-builder release.
  • Cut a new release of pydata-sphinx-theme to upload the new, well-formed, Poetry-compatible wheel.

@greschd
Copy link
Contributor

greschd commented Mar 20, 2023

despite the setting installer.modern-installation: false that we read in the poetry issues that is a workaround.

Interesting, for me this workaround was successful (in a private repo). Are you sure the setting was successfully propagated through the snok/install-poetry action?

@pantelis
Copy link

Are you sure the setting was successfully propagated through the snok/install-poetry action?

You are right - it wasnt. The correct workflow configuration should have been as shown below. With this configuration the site is successfully built.

  #----------------------------------------------
  #  -----  install & configure poetry  -----
  #----------------------------------------------
  - name: Install Poetry
    uses: snok/install-poetry@v1
    with:
      version: 1.4.1
      virtualenvs-create: true
      virtualenvs-in-project: true
      installer-parallel: true
  
  - uses: snok/install-poetry@v1
  - run: poetry config installer.modern-installation false  

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 29, 2023

This should be fixed in 1.3.2. 🎉

@dlqqq dlqqq closed this as completed Mar 29, 2023
@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 29, 2023

Oh wait, 1.3.2 isn't published on PyPi yet 😂

@dlqqq dlqqq reopened this Mar 29, 2023
@12rambau
Copy link
Collaborator

12rambau commented Mar 29, 2023

0.13.2 including your fix is out, is it solving this issue ?

@dlqqq
Copy link
Contributor Author

dlqqq commented Mar 29, 2023

@12rambau Yes, I have locally verified that this issue is fixed in 1.3.2. 🎉

Was a little too quick on the draw earlier 😅

@dlqqq dlqqq closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants