Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning to v4 PyAnsys actions multi-version docs (release/0.1) #227

Closed
wants to merge 4 commits into from

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Mar 21, 2023

See https://dev.docs.pyansys.com/how-to/documenting.html#multi-version-migration-from-pyansys-actions-v3-to-pyansys-actions-v4

Doing it as a patch-fix. We can keep this ansys-sphinx-theme version still (0.8.1). No need to release. It's only in case you need to do a patch release at some point on release/0.1

@RobPasMue RobPasMue self-assigned this Mar 21, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation bug Something isn't working labels Mar 21, 2023
@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 21, 2023
@RobPasMue RobPasMue marked this pull request as ready for review March 21, 2023 19:05
@RobPasMue RobPasMue changed the title Aligning to v4 PyAnsys actions multi-version docs Aligning to v4 PyAnsys actions multi-version docs (release/0.1) Mar 21, 2023
@RobPasMue
Copy link
Member Author

I don't really know why it's failing. Pinging @greschd here for whenever he has time. It might have something to do with poetry?

@greschd
Copy link
Member

greschd commented Mar 21, 2023

No need for a patch release here FMPOV, I edited the gh-pages branch directly. See https://composites.dpf.docs.pyansys.com/version/stable/

I think it's rather unlikely we'll have another 0.1 patch release, and if so we can just backport the necessary changes to get CI/CD running on the release branch.

@greschd
Copy link
Member

greschd commented Mar 21, 2023

@RobPasMue
Copy link
Member Author

Ah, got it! Then I'll just close this PR. Hopefully you won't need any patch releases :)

@RobPasMue RobPasMue closed this Mar 22, 2023
@greschd greschd deleted the fix/docs-on-release branch March 22, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants