Do not make use of pytest.warns(None)

[s-t-e-v-e-n-k]

pytest.warns(None) is an anti-pattern, and there are easier ways to accomplish both cases with how the code is leveraging pytest.warns(). Firstly, it can match on a specific warning and will assert that the warning is raised -- and it doesn't need to be used if we want to assert code raises no warnings, the standard library can do that directly. Furthermore, pytest.warns(None) is an error in Pytest 8 and above.

[clintonsteiner]

This is no longer needed due to similar test fixes which have been merged

[s-t-e-v-e-n-k]

with warnings.catch_warnings() is not sufficient, since it will swallow any warnings emitted, which is not what the test case is trying to accomplish. Setting the warnings filter to error will raise them as exceptions, like so:

with warnings.catch_warnings():
            warnings.simplefilter("error")

I'm happy to rebase this PR to just make that change.

[clintonsteiner]

Good callout, please do so