-
-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated warning message about outdated list of dependencies #4719
Conversation
@Saransh-cpp i guess this includes the changes requested by you. |
Hi, a small tip that It is nice to mention in the PR description where this change was originally requested or something like related or follow-up to #xyz :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -47,7 +47,7 @@ Dependencies | |||
|
|||
.. warning:: | |||
|
|||
The list of dependencies below might be outdated. Please refer to the ``pyproject.toml`` file to find all dependencies. | |||
The list of dependencies below might be outdated. Please use tools like [``pipdeptree``](https://github.com/tox-dev/pipdeptree) to find the latest dependencies of ``pybamm`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list of dependencies below might be outdated. Please use tools like [``pipdeptree``](https://github.com/tox-dev/pipdeptree) to find the latest dependencies of ``pybamm`` | |
The list of dependencies below might be outdated. Please use tools like [`pipdeptree`](https://github.com/tox-dev/pipdeptree) to find the latest dependencies of ``pybamm`` |
Maybe this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PyData Sphinx Theme already adds icons for popular websites including GitHub (as noted in the above screenshot), so we should be fine without rendering Markdown (because this is a docs-only page).
But, I don't recommend using tools like pipdeptree
in the first place, since as I mentioned in #4706 (comment), it cannot handle optional dependencies at the moment: tox-dev/pipdeptree#107. Neither can uv pip tree
: astral-sh/uv#4710. It is a metadata problem and not an implementation problem: pypa/packaging-problems#215
So, if we are to improve this warning message, we need something better here.
@@ -47,7 +47,7 @@ Dependencies | |||
|
|||
.. warning:: | |||
|
|||
The list of dependencies below might be outdated. Please refer to the ``pyproject.toml`` file to find all dependencies. | |||
The list of dependencies below might be outdated. Please use tools like [``pipdeptree``](https://github.com/tox-dev/pipdeptree) to find the latest dependencies of ``pybamm`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PyData Sphinx Theme already adds icons for popular websites including GitHub (as noted in the above screenshot), so we should be fine without rendering Markdown (because this is a docs-only page).
But, I don't recommend using tools like pipdeptree
in the first place, since as I mentioned in #4706 (comment), it cannot handle optional dependencies at the moment: tox-dev/pipdeptree#107. Neither can uv pip tree
: astral-sh/uv#4710. It is a metadata problem and not an implementation problem: pypa/packaging-problems#215
So, if we are to improve this warning message, we need something better here.
I apologies for the confusion caused here . |
I'll be happy to approve if we have something better here. :) We could just say something like, "Users are advised to manually check the list of dependencies to find out supported versions". Or, I like SciPy's idea – where they say, "whatever recent versions work": https://docs.scipy.org/doc/scipy/dev/toolchain.html#building-the-documentation, and only enforce or update the lower bound for a dependency only in the case there is a breakage with versions lower than it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @RohitP2005! Looks good to me. We should also update the versions as well, while we are at it:
@Saransh-cpp, does this fit your previous suggestion better? |
Co-authored-by: Agriya Khetarpal <[email protected]>
Co-authored-by: Agriya Khetarpal <[email protected]>
Happy to help anytime |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4719 +/- ##
===========================================
+ Coverage 99.22% 99.25% +0.02%
===========================================
Files 303 303
Lines 23070 23230 +160
===========================================
+ Hits 22891 23056 +165
+ Misses 179 174 -5 ☔ View full report in Codecov by Sentry. |
@agriyakhetarpal do u think, are there anything else that can be improved here |
No more improvements; I'll suggest @Saransh-cpp to review if he finds anything, otherwise, I shall merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RohitP2005 looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pr was requested by @Saransh-cpp at #4706 (comment) despite @agriyakhetarpal suggesting it was not necessary.
I agreed to add a link to the file instead of using another tool in my previous review.
@@ -49,7 +49,7 @@ PyBaMM requires the following dependencies: | |||
|
|||
.. warning:: | |||
|
|||
The list of dependencies below might be outdated. Please refer to the ``pyproject.toml`` file to find all dependencies. | |||
The list of dependencies below might be outdated. Users are advised to manually check the ``pyproject.toml`` file to find out supported versions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A link would be great :)
Co-authored-by: Saransh Chopra <[email protected]>
1c7cc70
Thanks @Saransh-cpp |
Description
This PR updates the warning message for required dependencies in the
index.rst
file. The previous message was unclear, and this change provides more specific instructions for users. No functional changes were made to the code, only to the documentation for better clarity.Fixes #<issue_number> (if applicable)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest
(or$ nox -s tests
)$ python -m pytest --doctest-plus src
(or$ nox -s doctests
)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick
.Further checks:
@Saransh-cpp