Apply suggestions from code review

Co-authored-by: Ioanna M Dimitriou H <[email protected]>
ptomato · Mar 28, 2024 · 837def6 · 837def6
1 parent 71f95c2
commit 837def6
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 8 deletions.
diff --git a/test/built-ins/TypedArray/from/from-array-mapper-detaches-result.js b/test/built-ins/TypedArray/from/from-array-mapper-detaches-result.js
@@ -4,7 +4,7 @@
 /*---
 esid: sec-%typedarray%.from
 description: >
-  Mapper function detaches result typed array.
+  If the mapper function detaches the result typed array, .from performs Set operation which ignores out-of-bounds indices.
 info: |
   %TypedArray%.from ( source [ , mapfn [ , thisArg ] ] )
 

diff --git a/test/built-ins/TypedArray/from/from-array-mapper-makes-result-out-of-bounds.js b/test/built-ins/TypedArray/from/from-array-mapper-makes-result-out-of-bounds.js
@@ -4,7 +4,7 @@
 /*---
 esid: sec-%typedarray%.from
 description: >
-  Mapper function makes result typed array out-of-bounds.
+  If the mapper function makes result typed array out-of-bounds, .from performs Set operation which ignores out-of-bounds indices.
 info: |
   %TypedArray%.from ( source [ , mapfn [ , thisArg ] ] )
 

diff --git a/test/built-ins/TypedArray/from/from-typedarray-into-itself-mapper-detaches-result.js b/test/built-ins/TypedArray/from/from-typedarray-into-itself-mapper-detaches-result.js
@@ -4,7 +4,7 @@
 /*---
 esid: sec-%typedarray%.from
 description: >
-  Mapper function detaches result typed array.
+  If the mapper function detaches the result typed array, .from performs Set operation which ignores out-of-bounds indices.
 info: |
   %TypedArray%.from ( source [ , mapfn [ , thisArg ] ] )
 

diff --git a/...uilt-ins/TypedArray/from/from-typedarray-into-itself-mapper-makes-result-out-of-bounds.js b/...uilt-ins/TypedArray/from/from-typedarray-into-itself-mapper-makes-result-out-of-bounds.js
@@ -4,7 +4,7 @@
 /*---
 esid: sec-%typedarray%.from
 description: >
-  Mapper function makes result typed array out-of-bounds.
+  If the mapper function makes result typed array out-of-bounds, .from performs Set operation which ignores out-of-bounds indices.
 info: |
   %TypedArray%.from ( source [ , mapfn [ , thisArg ] ] )
 

diff --git a/test/built-ins/TypedArray/from/from-typedarray-mapper-detaches-result.js b/test/built-ins/TypedArray/from/from-typedarray-mapper-detaches-result.js
@@ -4,7 +4,7 @@
 /*---
 esid: sec-%typedarray%.from
 description: >
-  Mapper function detaches result typed array.
+  If the mapper function detaches the result typed array, .from performs Set operation which ignores out-of-bounds indices.
 info: |
   %TypedArray%.from ( source [ , mapfn [ , thisArg ] ] )
 

diff --git a/test/built-ins/TypedArray/from/from-typedarray-mapper-makes-result-out-of-bounds.js b/test/built-ins/TypedArray/from/from-typedarray-mapper-makes-result-out-of-bounds.js
@@ -4,7 +4,7 @@
 /*---
 esid: sec-%typedarray%.from
 description: >
-  Mapper function makes result typed array out-of-bounds.
+  If the mapper function makes result typed array out-of-bounds, .from performs Set operation which ignores out-of-bounds indices.
 info: |
   %TypedArray%.from ( source [ , mapfn [ , thisArg ] ] )
 

diff --git a/test/built-ins/TypedArray/prototype/subarray/result-byteOffset-from-out-of-bounds.js b/test/built-ins/TypedArray/prototype/subarray/result-byteOffset-from-out-of-bounds.js
@@ -4,7 +4,7 @@
 /*---
 esid: sec-%typedarray%.prototype.subarray
 description: >
-  Result has correct the byteOffset when input is initially out-of-bounds.
+  Result has the correct byteOffset when input is initially out-of-bounds.
 info: |
   %TypedArray%.prototype.subarray ( start, end )
 

diff --git a/test/built-ins/TypedArray/prototype/with/index-validated-against-current-length.js b/test/built-ins/TypedArray/prototype/with/index-validated-against-current-length.js
@@ -8,10 +8,15 @@ description: >
 info: |
   %TypedArray%.prototype.with ( index, value )
 
+  1. Let O be the this value.
+  2. Let taRecord be ? ValidateTypedArray(O, SEQ-CST).
+  3. Let len be TypedArrayLength(taRecord).
   ...
   8. Else, let numericValue be ? ToNumber(value).
-  9. If IsValidIntegerIndex(O, 𝔽(actualIndex)) is false, throw a RangeError exception.
   ...
+  10. Let A be ? TypedArrayCreateSameType(O, « 𝔽(len) »).
+  ...
+  13. Return A.
 
 features: [TypedArray, resizable-arraybuffer]
 ---*/