Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start testing on Rails 8 final release #3437

Merged
merged 2 commits into from
Nov 8, 2024
Merged

Start testing on Rails 8 final release #3437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8947a8b
Start testing on Rails 8 final release
jcoyne Nov 7, 2024
abdd5e7
Ensure use of i18n-tasks ~> 1.0
jcoyne Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ruby.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@ jobs:
additional_name: [""]
include:
- ruby: "3.3"
rails_version: "8.0.0.rc2"
rails_version: "8.0.0"
additional_engine_cart_rails_options: --css=bootstrap
- ruby: "3.3"
rails_version: "8.0.0.rc2"
rails_version: "8.0.0"
additional_engine_cart_rails_options: --css=bootstrap --js=esbuild
additional_name: "/ esbuild"
- ruby: "3.2"
Expand Down
2 changes: 1 addition & 1 deletion blacklight.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ Gem::Specification.new do |s|
s.add_development_dependency "rubocop-capybara"
s.add_development_dependency "rubocop-rspec_rails"
s.add_development_dependency "rubocop-factory_bot"
s.add_development_dependency "i18n-tasks"
s.add_development_dependency "i18n-tasks", '~> 1.0'
s.add_development_dependency "solr_wrapper"
end
1 change: 1 addition & 0 deletions spec/test_app_templates/Gemfile.extra
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
gem 'rails-controller-testing'
gem 'rails-i18n', github: 'Shopify/rails-i18n', branch: 'schwad_rails_8'

unless ENV['VIEW_COMPONENT_VERSION'].to_s == ""
gem 'view_component', ENV.fetch('VIEW_COMPONENT_VERSION')
Expand Down