Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating expensive Path objects in split creation code #24317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NikhilCollooru
Copy link
Contributor

@NikhilCollooru NikhilCollooru commented Jan 2, 2025

Description

Avoid creating expensive Hadoop Path objects in split creation code. Path object creation is cpu intensive.

Motivation and Context

We observed that when coordinator is running hot, a good amount of CPU is being spent on Hadoop Path object creation. So we want to reduce that especially in split creation code path.

Impact

None

Test Plan

unit tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== NO RELEASE NOTE ==

@NikhilCollooru NikhilCollooru requested a review from a team as a code owner January 2, 2025 23:45
@arhimondr
Copy link
Member

LGTM % CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants