[native] Change C-style casts to C++-style #24237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
infvg and
wanglinsong
and removed request for
a team
jkhaliqi
force-pushed
the
jk_cve
branch
2 times, most recently
from
a3998f5 to
2507ca2
Compare
jkhaliqi
changed the title
jkhaliqi
force-pushed
the
jk_cve
branch
4 times, most recently
from
b902b86 to
fd5d1eb
Compare
| @@ -65,10 +65,10 @@ void toThrift(const std::vector<P>& p, std::vector<T>& t) { | |||
| } | |||
|
|
|||
| void toThrift(const protocol::TaskState& proto, thrift::TaskState& thrift) { | |||
| thrift = (thrift::TaskState)((int)proto); | |||
| thrift = (thrift::TaskState)(static_cast<int>(proto)); | |||
There was a problem hiding this comment.
Should there be a static_cast from int -> thrift::TaskState enum as well ?
Same comment for the line below also.
There was a problem hiding this comment.
Hey @aditi-pandit good catch, updated with the change, thank you!
|
@ethanyzhang imported this issue into IBM GitHub Enterprise |
jkhaliqi
force-pushed
the
jk_cve
branch
2 times, most recently
from
67a80e5 to
9bb06f3
Compare
jkhaliqi
force-pushed
the
jk_cve
branch
2 times, most recently
from
158b1f8 to
2313697
Compare
aditi-pandit
requested changes
Jan 16, 2025
There was a problem hiding this comment.
This is a code generated file. We will have to change the code generation logic instead.
Please remove this file from the PR.
There was a problem hiding this comment.
Good catch, Added change to mustache file ProtocolToThrift-cpp.mustache thank you!
jkhaliqi
force-pushed
the
jk_cve
branch
2 times, most recently
from
9c300a8 to
2eec3f6
Compare
|
@jkhaliqi : Lets wait until the builds pass to submit this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the security guideline in
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es49-if-you-must-use-a-cast-use-a-named-cast
Covers the findings in the list from this issue and
closes #2493
Contributor checklist
Release Notes