[native] Add LinuxMemoryChecker check/warning to ensure system-mem-limit-gb is reasonably set #24149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestodb-ci
requested review from
a team,
psnv03 and
pramodsatya
and removed request for
a team
minhancao
changed the title
minhancao
force-pushed
the
linuxmemorychecker_mem_limit_check
branch
from
4478ae1 to
15f55bb
Compare
minhancao
changed the title
minhancao
force-pushed
the
linuxmemorychecker_mem_limit_check
branch
from
15f55bb to
7646600
Compare
czentgr
reviewed
Nov 27, 2024
minhancao
force-pushed
the
linuxmemorychecker_mem_limit_check
branch
2 times, most recently
from
8da401b to
4ae2cee
Compare
pramodsatya
reviewed
Dec 10, 2024
presto-native-execution/presto_cpp/main/tests/LinuxMemoryCheckerTest.cpp
Outdated
Show resolved
Hide resolved
| std::string statFile_; | ||
| std::string memInfoFile_ = "/proc/meminfo"; |
There was a problem hiding this comment.
Nit: const std::string kMemInfoFile_
There was a problem hiding this comment.
This has to stay as a non-const variable since I need to change its path to point to the meminfo test file when I am running the LinuxMemoryCheckerTests.
minhancao
force-pushed
the
linuxmemorychecker_mem_limit_check
branch
from
85b3b9d to
dab2335
Compare
majetideepak
requested changes
Jan 2, 2025
czentgr
reviewed
Jan 9, 2025
| VELOX_CHECK_LE( | ||
| config_.systemMemLimitBytes, | ||
| getActualTotalMemory(), | ||
| "system-mem-limit-gb is higher than the actual total memory capacity."); |
There was a problem hiding this comment.
Can we add the actual numbers that were found if this fails? Especially because the total memory capacity doesn't come from the config but is determined.
| // For cgroup v1, memory.limit_in_bytes can default to a really big numeric | ||
| // value in bytes like 9223372036854771712 to represent that | ||
| // memory.limit_in_bytes is not set to a value. The default value here is | ||
| // set to PAGE_COUNTER_MAX, which is LONG_MAX/PAGE_SIZE on 64-bit platform. |
There was a problem hiding this comment.
Nit: "on the 64-bit platform".
| @@ -0,0 +1 @@ | |||
| 9223372036854771712 | |||
There was a problem hiding this comment.
As discussed, lets not add example files but generate the content in memory.
The logic relies on reading files. So we could write to the temp dir path which is used in other tests and use those files for the test.
minhancao
force-pushed
the
linuxmemorychecker_mem_limit_check
branch
2 times, most recently
from
71c9fa9 to
89a50a8
Compare
…ystem-mem-limit-gb < actual total memory capacity.
minhancao
force-pushed
the
linuxmemorychecker_mem_limit_check
branch
from
89a50a8 to
163880b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add LinuxMemoryChecker check and warning to ensure system-memory-gb < system-mem-limit-gb < actual total memory capacity.
For cgroup v1:
Set actual total memory to be the smaller number between /proc/meminfo and memory.limit_in_bytes
For cgroup v2:
Set actual total memory to be the smaller number between /proc/meminfo and memory.max
If memory.max contains "max" string, then look at /proc/meminfo for the MemTotal, otherwise use the value in memory.max.
VELOX_CHECK_LT(system-mem-limit-gb, actual total memory capacity):
Warning to output to worker's log:
Motivation and Context
Impact
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.