-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Fix: Okio CVE-2023-3635 + OkHttp Jar Update #23796
Open
Mariamalmesfer
wants to merge
1
commit into
prestodb:master
Choose a base branch
from
Mariamalmesfer:okie-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+701
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mariamalmesfer
force-pushed
the
okie-fix
branch
2 times, most recently
from
October 13, 2024 09:24
1e17bcc
to
8bed2f9
Compare
Mariamalmesfer
force-pushed
the
okie-fix
branch
from
October 13, 2024 09:41
8bed2f9
to
4bd3bc1
Compare
Mariamalmesfer
force-pushed
the
okie-fix
branch
3 times, most recently
from
October 15, 2024 13:51
f8715a8
to
e3b47f0
Compare
Mariamalmesfer
force-pushed
the
okie-fix
branch
5 times, most recently
from
November 4, 2024 06:46
e13efb9
to
dab801a
Compare
Thanks for the release note entry! Nit to remove
|
Mariamalmesfer
force-pushed
the
okie-fix
branch
12 times, most recently
from
November 7, 2024 22:14
af5b4c3
to
ef04384
Compare
Mariamalmesfer
force-pushed
the
okie-fix
branch
7 times, most recently
from
December 10, 2024 21:41
5de7a82
to
a0525f5
Compare
Mariamalmesfer
force-pushed
the
okie-fix
branch
2 times, most recently
from
December 25, 2024 10:32
5549d70
to
472111e
Compare
Mariamalmesfer
force-pushed
the
okie-fix
branch
from
January 7, 2025 13:21
1ed5d8a
to
406b1d1
Compare
Mariamalmesfer
force-pushed
the
okie-fix
branch
4 times, most recently
from
January 15, 2025 18:18
9b55b09
to
83aa236
Compare
Mariamalmesfer
force-pushed
the
okie-fix
branch
from
January 15, 2025 20:25
83aa236
to
cd95fc3
Compare
aaneja
reviewed
Jan 17, 2025
aaneja
reviewed
Jan 17, 2025
* A distinguished name (DN) parser. This parser only supports extracting a string value from a DN. | ||
* It doesn't support values in the hex-string style. | ||
*/ | ||
final class DistinguishedNameParser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a direct like to the OkHttp code this was copied from
ZacBlanco
reviewed
Jan 17, 2025
Mariamalmesfer
force-pushed
the
okie-fix
branch
2 times, most recently
from
January 21, 2025 09:53
85bca20
to
f3d345d
Compare
aaneja
previously approved these changes
Jan 22, 2025
ZacBlanco
reviewed
Jan 22, 2025
presto-client/src/main/java/okhttp/internal/tls/DistinguishedNameParser.java
Outdated
Show resolved
Hide resolved
Mariamalmesfer
force-pushed
the
okie-fix
branch
2 times, most recently
from
January 22, 2025 10:25
72a9e67
to
d4aee3e
Compare
…n 4.12.0 to address CVE-2023-3635.
Mariamalmesfer
force-pushed
the
okie-fix
branch
from
January 22, 2025 12:03
d4aee3e
to
4bbd3de
Compare
ZacBlanco
approved these changes
Jan 22, 2025
aaneja
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Okio security vulnerability (CVE-2023-3635) by upgrading from version 1.17.2 to 3.6.0. It also includes an update to the OkHttp jar from 3.9.0 to 4.12.0
Motivation and Context
A flaw was found in Okio’s GzipSource class that doesn’t handle exceptions properly, allowing potential Denial of Service (DoS) attacks with malformed files.
CVE-2023-3635: Details
Impact
Image Scan showed the vulnerability have been removed.
correlation-report-ibm-lh-presto-okie check.csv
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.