Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in French translation #1220

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

deining
Copy link
Contributor

@deining deining commented Jan 3, 2025

This PR fixes a few typos I spotted in the French translation.

Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to be using a bot? Generally little reason to be referring to the v8 docs these days, they're 5+ years old (and probably diverge from the English docs). We do also have a policy that contributors only author in their native language for most cases, helps keep the quality up and avoid problematic mistranslations.

Not that this PR seems to be problematic itself, but I do want to avoid situations in which contributors are setting bots (or chatgpt and the like) loose on the repo to "correct" translations.

@deining
Copy link
Contributor Author

deining commented Jan 3, 2025

Do you happen to be using a bot?

No.

Generally little reason to be referring to the v8 docs these days

I agree.

Not that this PR seems to be problematic itself

Glad to hear that. This PR will brings minor improvements, but I agree its relevance is limited.

but I do want to avoid situations in which contributors are setting bots (or chatgpt and the like) loose on the repo to "correct" translations.

No, this is not my intent at all and won't happen.

Looking forward seeing my PR merged.

@rschristian
Copy link
Member

Fair enough.

"Generally little reason to be referring to the v8 docs these days" was more of a question why you were really looking at these, users shouldn't really be referring to them so it tends to be a good indicator of bots/automatic translations.

@rschristian rschristian merged commit c1f0baa into preactjs:master Jan 3, 2025
5 checks passed
@deining deining deleted the fix-typos-fr branch January 3, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants