Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SetupLogging not being called in game test scenario #6504

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

peppy
Copy link
Member

@peppy peppy commented Jan 22, 2025

@bdach
Copy link
Collaborator

bdach commented Jan 22, 2025

Sorta tangential, but in scanning around usages of SetHost() to check if anything else might need a SetupLogging() call, I noticed template game projects calling SetHost(), which on closer inspection was redundant because they would call AddGame() shortly after which also sets the host (and also does the logging setup with this change). So I just deleted the SetHost() calls in 6ef2f54. They should have probably been removed as far back as #4885.

@bdach bdach merged commit c54ee8a into ppy:master Jan 22, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants