New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change IsRootedAt method from internal to public in DrawableExtensions #6500

Merged

smoogipoo merged 1 commit into ppy:master from Rudicito:IsRootedAt-from-internal-to-public

Jan 21, 2025

Contributor

Rudicito commented Jan 20, 2025 •

edited

Loading

I think it can be useful to be able to use this method outside the framework. For example, I need it for this :

bool sliderDraggedInItself = inputManager.DraggedDrawable.IsRootedAt(this);

if (Expanded.Value || IsHovered || sliderDraggedInItself)
{
    // Do things
}

Detailed example : ppy/osu#31596


          Change IsRootedAt method from internal to public

03be972

pull-request-size bot added the size/XS label

Rudicito mentioned this pull request

Fix toolbox settings hiding when dragging a slider ppy/osu#31596

Draft

smoogipoo merged commit 0628d99 into ppy:master

13 of 14 checks passed

Rudicito mentioned this pull request

Fix player settings in replay hiding when dragging a slider ppy/osu#31593

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels