Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React Native New Architecture #47

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

mugikhan
Copy link
Contributor

@mugikhan mugikhan commented Sep 18, 2024

Description

This PR upgrades the React Native version to the latest stable release and removes the usage of the nativeCallSyncHook() method, which previously detected if remote chrome debugging was being used as it is not supported when building for new architecture. This change uses the interoperability layer provided by react native and ensures that the package is compatible with new architecture with bridgeless mode enabled. It will also work under the old architecture ensuring backwards compatibility.
This is a safe interim solution before upgrading the package to a TurboModule in the future.

There is a an error when compiling for New Architecture with bridgeless mode explicitly disabled. It is however recommended to keep bridgeless mode enabled for the benefits it offers.

Work done

  • Bump react native version
  • Remove use of nativeCallSyncHook()
  • Upgrade ruby version

Testing

  • Tested by running the internal tests app which use an older version of react native (v0.73).
  • Tested on independent demo apps using react native versions 0.74 and 0.75.
  • Tested by running react-native-supabase-todolist with new architecture enabled.

- Remove use of nativeCallSyncHook()
- Upgrade ruby version
@mugikhan mugikhan changed the title Support React native New Architecture Support React Native New Architecture Sep 18, 2024
stevensJourney
stevensJourney previously approved these changes Sep 19, 2024
Copy link
Collaborator

@stevensJourney stevensJourney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.

@mugikhan mugikhan merged commit e971eeb into main Sep 20, 2024
3 checks passed
@mugikhan mugikhan deleted the feat/support-new-arch-interop branch September 26, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants