Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use install_modules_dependencies() on iOS for newer react-native versions #44

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

mugikhan
Copy link
Contributor

@mugikhan mugikhan commented Sep 9, 2024

Description

To ensure all necessary headers are included during the build process for React Native 0.74+, we were previously missing some header directories on iOS. install_modules_dependencies() installs React-Core and RCT-Folly as well as some New Architecture specific dependencies if New Architecture is enabled.
This change ensures all the required packages are included on newer react-native versions while maintaining backwards compatibility.

Note: This does not make the package compatible with New Architecture.

Work done

  • Use install_modules_dependencies() if available.

@mugikhan mugikhan merged commit 2f5eb63 into main Sep 9, 2024
3 checks passed
@mugikhan mugikhan deleted the fix/react-native-0.75-support branch September 9, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants